fix(@capacitor/haptics): prevent thread overload by reusing CHHapticEngine#2340
Open
GorkaMinus wants to merge 2 commits intoionic-team:7.xfrom
Open
fix(@capacitor/haptics): prevent thread overload by reusing CHHapticEngine#2340GorkaMinus wants to merge 2 commits intoionic-team:7.xfrom
GorkaMinus wants to merge 2 commits intoionic-team:7.xfrom
Conversation
Contributor
|
Hey @GorkaMinus, sorry for the delay, I changed the branch to 7.x, as since 8.x, the capacitor haptics plugin now lives in its own repository - https://github.com/ionic-team/capacitor-haptics. If you can, open an equivalent PR to that repository in order to be able to merge it into the latest version. If you have any questions feel free to ask, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Prevent iOS app freeze by reusing
CHHapticEngineinstanceThis PR addresses an issue where calling
Haptics.vibrate()rapidly (e.g., from a fast-scrolling picker in my case) causes the app to hang or crash on iOS. The problem stems from creating a newCHHapticEngineinstance on each call, which leads to excessive thread creation and eventual system overload.Solution
CHHapticEngineinstance across multiple vibration calls.This fix improves performance and stability, especially in high-frequency vibration scenarios.
Related Issue #1960